[Bug 451407] Review Request: python-webtest - Helper to test WSGI applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451407


Tim Lauridsen <tim.lauridsen at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tim.lauridsen at googlemail.co
                   |                            |m
               Flag|                            |fedora-review+

Bug 451407 depends on bug 455111, which changed state.

Bug 455111 Summary: Review Request: python-webob - WSGI request and response object
https://bugzilla.redhat.com/show_bug.cgi?id=455111

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE



--- Comment #5 from Tim Lauridsen <tim.lauridsen at googlemail.com>  2008-10-13 01:27:44 EDT ---
I'll take this one.

rpmlint is silent
source match upstream
bdc4f8597c1d9500636f09bf52ed9d33  WebTest-1.0.tar.gz
bdc4f8597c1d9500636f09bf52ed9d33  WebTest-1.0.tar.gz


MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* summary and description fine
* correct buildroot
* %{.dist} is used
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* not a GUI app
* no -devel sub-package necessary
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* no locale data
* no Requires(pre,post)
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime


SHOULD:
* package should include license text in the package and mark it with %doc
* package should build on i386
? package should build in mock
 - I haven't tried, but I don't think it'll be a problem


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.