[Bug 466688] Review Request: mpfi - An interval arithmetic library based on MPFR

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 13 08:19:32 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466688


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #1 from Ralf Corsepius <rc040203 at freenet.de>  2008-10-13 04:19:29 EDT ---
MUSTFIX:

- Package's NEVR doesn't comply to 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Non-Numeric_Version_in_Release

- Package doesn't install *info's correctly.
Something similar to this is missing:

Requires(post): /sbin/install-info
Requires(pre): /sbin/install-info

%post
/sbin/install-info \
  --info-dir=/usr/share/info /usr/share/info/mpfi.info.gz || :

%preun:
if [ $1 = 0 ]; then
  /sbin/install-info --delete \
    --info-dir=/usr/share/info /usr/share/info/mpfi.info.gz || :
fi


- Package split: Provided this package doesn't provide any run-time usable
library or applications, and contains devel-docs only, the "mpfi base package"
doesn't make sense, IMO.

My recommendation: Move the info file to *-devel and don't ship a base package.


CONSIDER:

I am not sure if shipping this package makes much sense, because browsing their
site indicates this project might be pretty much dead (Take into account, you
are building from a 2.5 years old "release candidate" tarball).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list