[Bug 466660] Review Request: sympy - A Python library for symbolic mathematics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466660





--- Comment #3 from Jon Ciesla <limb at jcomserv.net>  2008-10-13 12:11:11 EDT ---
rpmlint on SRPM is clean

rpmlint on RPMs:

sympy.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/sympy/utilities/compilef.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sympy.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/sympy/solvers/numeric.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sympy.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/sympy/mpmath/elliptic.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sympy.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/sympy/mpmath/tests/test_elliptic.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

Since these aren't meant to be executable, it would be good to patch out the
shebangs and send the patch upstream.

Otherwise, full review looks great.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.