[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464424


Dominik 'Rathann' Mierzejewski <rpm at greysector.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #51 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2008-10-13 13:03:17 EDT ---
(In reply to comment #48)
> Since the discussion on fedora-packaging seems to have ceased without reaching
> a conclusion and there isn't a need to be able to have many versions of Gromacs
> concurrently installed, I have removed the support for environment-modules and
> just renamed all binaries to start with g_ .

Excellent.

> Since everything resides in standard locations the package should now be
> acceptable for distribution, please review.

> gromacs-bash.x86_64: W: conffile-without-noreplace-flag
> /etc/bash_completion.d/gromacs4

This could be easily fixed.

And one last nitpick:
%{_bindir}/g_mdrun_mpid
is inconsistently named in comparison to all the other binaries which have _d
suffix.

You can fix both of these upon import. This package is now APPROVED.
I have just sponsored you, so you can request the creation of CVS module for
gromacs now and import the package after setting up your CVS access.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.