[Bug 457281] Review Request: unikurd-fonts - A widely used Kurdish font

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 13 20:38:11 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457281


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #7 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2008-10-13 16:38:08 EDT ---
(In reply to comment #6)
> (In reply to comment #5)
> My version guess is based on output from gnome-font-viewer.
> Says: "Version 1.00"

Unfortunately since 1.00 is the default in many font creation tools that does
not mean anything. Experience shows you can have 6-7 successive font updates
that all pretend they are 1.00 :(

Unless you've verified with upstream 1.00 is really 1.00, and the next one will
be something else, the only safe version to use with fonts that declare
themselves as 1.00 is the sfd/ttf file timestamp.

> > 2. Please add a fontconfig file as Ankur suggested. Since unikurd covers
> > unicode blocks Behdad is interested in, I think it shouldn't be too hard to get
> > him to help you (I doubt he wants you to stomp on farsi)
> > ⇒ add some fontconfig rules

> I am somewhat busy at the moment, this might take me some time, but I am
> definitely for have it packed.

Ok, I guess this is not a blocker but it would be really nice to have.

> > Non blocking remarks
> > 
> > 1. please have upstream add the GPL font exception to their font
> 
> See Fedora fonts ml. Just pinged them.
> 
> > 2. please have upstream provide sfd sources if they use fontforge
> 
> See Fedora fonts ml.

This was just to trace it :) You've done it publicly and that's very good.

> 
> http://eva.fit.vutbr.cz/~xnowak01/Fedora/unikurd-web/unikurd-web-font.spec

Ok, some more nitpicking: please use %defattr(644,root,root,755)

So:
1. fix the version
2. use %defattr(644,root,root,755)
3. add fontconfig rules (this can wait after import)
4. continue to ask to GPL exception and sfds

But in the meanwhile the package is APPROVED. Thank you for your persistence.

You can continue from 
http://fedoraproject.org/wiki/Font_package_lifecycle#3.a now. Please don't
forget the comps and wiki bits.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list