[Bug 466789] Review Request: jmol - an open-source Java viewer for chemical structures in 3D

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 14 09:03:18 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466789





--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2008-10-14 05:03:17 EDT ---
(In reply to comment #1)
> * Correct path for icon should be
> "http://wiki.jmol.org:81/images/Jmol_icon_128.png"

With this I get during build

/var/tmp/rpm-tmp.65853: line 52: unexpected EOF while looking for matching `"'
error: Bad exit status from /var/tmp/rpm-tmp.65853 (%install)

It seems that %{SOURCE2} somehow drops the first quotation mark.

Everything else should be fixed. Also I branched the documentation to separate
packages. rpmlint output is clean for spec file and the three packages.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/jmol.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/jmol-11.6-2.10081svn.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list