[Bug 445537] Review Request: tightvnc - VNC software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=445537





--- Comment #9 from Dan Horák <dan at danny.cz>  2008-10-14 05:15:32 EDT ---
formal review is here, see the notes below:

OK source files match upstream (checked with diff between the included sources
and fresh export from SVN)
BAD package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
BAD compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
BAD final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
BAD owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
BAD scriptlets present
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK* is a GUI app, desktop file installed

- include instructions for getting the sources - see
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control

- snapshot package must contain date in the Release tag - see
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages

- don't disable optimization (export CFLAGS="$RPM_OPT_FLAGS -O0") - drop the
-O0

- rpmlint complains:
tightvnc-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/tightvnc-1.5.0-svn2975/unix/xserver/*/*.[ch] (about 12 files)
 run "chmod a-x unix/xserver/*/*.[ch]" after copying the xorg-x11-server-Xorg
sources into the tightvnc tree
tightvnc-server.x86_64: W: incoherent-init-script-name vncserver
 can be ignored

- the EVR in Obsoletes/Provides must be greater than the EVR of the package we
are replacing (use EVR=4.1.2-36, no dist tag) - see
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages

- server subpackage should have "Requires: xorg-x11-server-Xorg" for the
ownership of %{_libdir}/xorg/modules/extensions/

- the "always succeed" clause (" || :") is missing from the server's postun
scriptlet and from gtk-update-icon-cache too - see
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets
and
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

- remove the X-Red-Hat-Extra from the desktop file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.