[Bug 466762] Review Request: ipmitool - Utility for IPMI control

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466762





--- Comment #6 from Jan Safranek <jsafrane at redhat.com>  2008-10-14 07:58:07 EDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > > service-default-enabled /etc/rc.d/init.d/ipmievd
> > 
> > I agree that it should not be.  Disabling its autostart is part of the patch
> > submitted in bug 466343:
> > 
> > -# chkconfig: 345 99 00
> > +# chkconfig: - 99 00
> >
> > > incoherent-init-script-name ipmievd
> > > Fixable, or does this coorespond with what's in openipmi-tools?
> > 
> > IMHO, there's nothing to fix here - the init script specifically starts
> > ipmievd, not ipmitool... rpmlint is being a bit silly here.
> 
> Agreed.

Rpmlit checks also Default-Start, I'll remove the runlevels from there.

> > "Obsoletes: OpenIPMI-tools < 2.0.14-3" missing (and possibly "Provides:
> > OpenIPMI-tools = 2.0.14-3" if you think it's necessary, see
> > http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages)

Obsoletes: added, Provides: sounds silly to me.

> > From bug 466343: "BuildRequires: freeipmi-devel" should be added, or freeipmi
> > support explicitly disabled for reproducible builds.

Here I am not sure if we want dependency on FreeIPMI... It was not there before
and most users won't need it. I'll check it together with pknirsch and we'll
decide.

> > From bug 466343: configure with --disable-dependency-tracking for slight build
> > speedup and cleaner build logs?
> 
> Works for me.

Done.

> > Source0 URL does not match recommended sf.net one:
> > http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
> 
> The DNS resolves the same way, but there's no harm fixing it.

Fixed.

> > Wouldn't configuring with --enable-file-security be desirable?
> 
> Possbily, not sure of the ramifications.  Jan?

It just adds additional checks when opening files (like owner, inode, link
count etc.). It does not harm nor introduce any performance impact. I'll add it
there. 

> > "Requires: OpenIPMI" missing?
> 
> Probably, yes, I think I misunderstood the relationship here.  Not needed to
> build, but it would require at runtime, no?

AFAIK, ipmitools talks to OpenIPMI driver via /dev/ipmi0. It does not link with
OpenIPMI libraries. One may use ipmitool when talking to remote host over IP,
completely without need of OpenIMPI.


I'll check the freeipmi-devel issue and post new .spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.