[Bug 462818] Review Request: perl-Net-SMTP-SSL - SSL support for Net::SMTP

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 14 16:21:39 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462818





--- Comment #7 from Dan Nicholson <dbn.lists at gmail.com>  2008-10-14 12:21:37 EDT ---
(In reply to comment #6)
> OK, that looks fine.
> 
> A couple of minor comments:
> 
>  1. Please bump the release number of the package every time you make a change
> that anyone else (e.g. a reviewer) will see; this removes a possible source of
> confusion about which version of a package any particular comment applies to,
> and once you're building packages in Fedora, will ensure that packages you
> build and subsequently release are consistent with any that people may build
> locally from CVS.

Certainly.

>  2. I find it aids readability to append a "/" to directories included in
> %files lists, just to emphasize that they are directories (which in many cases
> will include further files, though that's not the case here), e.g.
> dir %{perl_vendorlib}/Net/

Fair enough - one character for better readability can't hurt.

> APPROVED.
> 
> Let me know your account name in the Fedora Account System and I'll sponsor you
> for membership of the Fedora Packager CVS Commit Group.

Account name is "dbn". Hopefully I have all that stuff set up appropriately.
Please let me know if there are any hiccups with the account.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list