[Bug 461699] Review Request: remoot - ReMoot is a remote control wrapper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461699





--- Comment #6 from Fabian Affolter <fabian at bernewireless.net>  2008-10-14 19:07:48 EDT ---
(In reply to comment #5)
>  [!] Sources used to build the package matches the upstream source, as provided
> in the spec URL.
>     006430c9ee24d6645a10693c5a075c1722876e21 remoot-0.9.tar.gz

tarball replaced, b94e5870308b366fafc9e9018edd6ac6

> ISSUES
> 1. two <code> have slipped in the Requires: perl line. Please replace it with
>   perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

fixed, copy-and-paste error 

> 2. please use iconv (plus touch -r to preserve the timestamp) to fix this. it's
> cosmetic but too easy to not fix it

fixed

> 3. The BR for perl(ExtUtils::MakeMaker) is useless. You are not using it.

fixed

> 3. Some of the "Requires" line are not needed either, rpmbuild peeks them
> automatically. Your current version of the spec leads to:
> [wolfy at wolfy2 tmp]$ rpm -qpR  remoot-0.9-2.fc10.noarch.rpm

fixed

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/remoot.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/remoot-0.9-3.fc9.src.rpm

Scratch builds:
http://koji.fedoraproject.org/koji/taskinfo?taskID=881136

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.