[Bug 445537] Review Request: tightvnc - VNC software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=445537





--- Comment #11 from Dan Horák <dan at danny.cz>  2008-10-15 09:18:17 EDT ---
Yet 2 little issues
- the License tag should be GPLv2+ (sorry I missed that in the first round)
- include instructions for getting the sources - see
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
(svn export https://vnc-tight.svn.sourceforge.net/svnroot/vnc-tight/trunk -r
%{revision} tightvnc; tar czvf ...)

And one suggestion - can you move this section

cp -r %{_datadir}/xorg-x11-server-source/* unix/xserver
pushd unix/xserver
for all in `find . -type f -perm -001`; do
 chmod -x "$all"
done
patch -p0 < ../xserver.patch

from %build to %prep, because this is in fact source preparation too.

And last thing (not related to the review) could be refreshing the
xserver.patch, because it applies quite unclean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.