[Bug 466737] Review Request: matio - Library for reading/writing Matlab MAT files

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 16 14:31:07 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466737





--- Comment #2 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2008-10-16 10:31:06 EDT ---
Patch_fuzz: I'm on Fedora-8. So, patches are generated that way with gendiff.
Also, I Plan to have matio in F-9 (maybe F-8). The patches have been sent
upstream anyway. (still not sure they have been received).

Missing r: True, typo.

#sed -i.fortranpath2 ... : yes, matio-1.3.3-fortranpath2.patch prevent to 
dynamic patch configure and configure.ac.

rpath: there is differents ways to disable rpath related to the reason why they
are there. Here is is because of patched autotools. our autotools doesn't
create rpathes, so it is easier to avoid with patching libtool.

docs and the pdf: The comment leave in the %install section. pdf is disabled
because it duplicates with doxygen. it doesn't seems interesting to have docs
twices.

The problem with the path for the fortran files is that they are listed in the
src/Makefile.am whereas present in the src/fortran/ directory. There is two way
to fix this either move back the src/fortran/* to src/* or to list the fortran
files in their own directory (src/fortran/Makefile.am  using subdir += fortran
in src/Makefile.am)
This problem has nothing to do with rpm but with "autotools preference" 
At least, that's what I expect.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list