[Bug 467154] Review Request: libvirt-qpid - An interface with libvirt using QMF (qpid modeling framework) which utilizes the Advanced Message Queuing protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467154





--- Comment #1 from David Lutterkort <lutter at redhat.com>  2008-10-16 21:35:08 EDT ---
Can you run rpmlint over it and fix the errors and warnings it produces ? Once
that's done, I'll do a more thorough review. Here's a few more obvious nits:

* change the make line in %build to

  make %{?_smp_mflags}

* Don't comment out Url and Buildroot, and make sure Buildroot is set to one of
the recommended values in the guidelines

* You use /usr/share in %files .. use %{_datadir} instead

* Why do you use AutoReq: no - is the versioning of the qpid libraries
insufficient ? If so, you should raise that with them

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.