[Bug 427706] Review Request: python-urwid - console user interface for python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=427706


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




--- Comment #14 from Jason Tibbitts <tibbs at math.uh.edu>  2008-10-17 01:12:23 EDT ---
I'm looking at some of the older tickets and thought I'd take care of this one.
 I'm sorry you've had to wait so long.  Are you still interested in getting
this package into Fedora?  If so, I'll review it, but I need to note a couple
of things.  First off, rpmlint does spew a couple of complaints:
  python-urwid.x86_64: E: non-standard-executable-perm 
   /usr/lib64/python2.5/site-packages/urwid/str_util.so 0775
This one is some weird bug somewhere that has nothing to do with your package;
occasionally the permissions on .so files built by python come out wrong.  I
have no idea what causes it, but we're just ignoring it as the packages
generated by the buildsystem seem to come out OK.

  python-urwid.x86_64: W: incoherent-version-in-changelog 0.9.8.2-2 
   0.9.8.2-1.fc10
You have an entry for 0.9.8.2-2 (i.e release 2) but the spec has Release: 1.

Also, it seems that 0.9.8.3 is out; would you like to update the package?

It seems reasonable to package up the examples (those .py files in the top
level which aren't setup.py) as documentation.  Generally I'd recommend that
you make them not executable but that's not necessary as long as they don't
drag in additional dependencies.

There is an actual test suite included as test_urwid.py which, surprisingly,
seems to run standalone.  You should call it in a %check section:
  %check
  %{__python} test_urwid.py
We always want to run test suites when possible, since we want as many sanity
checks as possible.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.