[Bug 466692] Review Request: iml - Finds solutions to systems of linear equations over integers

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 17 18:38:27 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466692


Patrice Dumas <pertusus at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




--- Comment #1 from Patrice Dumas <pertusus at free.fr>  2008-10-17 14:38:26 EDT ---
I don't think it makes sense to package a main iml package with only
doc, just put everything in -devel.

doc/liblink should be shipped.

I don't really like the name, it is very short and prone to conflicts, see
http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Use_of_common_namespace

I doubt that upstream is willing to reconsider th ename, though.

I propose adding 

%check
make check

You could ship ChangeLog if you feel like it.

rpmlint gives:
iml.i386: E: no-binary
iml-devel.i386: W: no-documentation
iml-debuginfo.i386: E: empty-debuginfo-package

The 2 first should be fixed by removing main package.

You can fix the 3rd if you want to (it is mandated by the guidelines,
but I disagree, and I will approve even with this issue).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list