[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 17 21:00:48 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=244192





--- Comment #34 from Andrew Overholt <overholt at redhat.com>  2008-10-17 17:00:47 EDT ---
This looks good to me, Rob.  I'll do a closer check on Monday but my one
suggestion right now is to change the %files line to be:

%{eclipse_base}/dropins/anyedit

instead of the explicit plugin since that way you own the directories too.

Also, note that it's not strictly required to do gcj stuff if you don't want to
(I actually disabled it in my test build since I don't have gcj installed).

Oh, and I guess you should make the requirement on eclipse-platform be >= 3.4.0
since dropins is new in 3.4 and wasn't in 3.3.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the package-review mailing list