[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461912





--- Comment #4 from Sergio Pascual <sergio.pasra at gmail.com>  2008-10-18 13:42:24 EDT ---
I have added the dependence in desktop-file-utils to build the package. 

   * In Source0 you can use the %{name} macro instead of puzzles if you want
   * BuildRequires: sed is in the exception list, so it can be safely removed.
Perl it isn't but is pulled anyway. You can remove it also or leave it to be in
the safe side. You have to add desktop-file-utils too.
   * Source doesn't match upstream source (there is a new version upstream)
   * In description there's a typo: this is a collection -> This is a colection
   * In %setup, you can run sed in place with 
     sed -e "s/CFLAGS = .*-g/CFLAGS = %{optflags}/" -i Makefile
   * The naming of the binaries seems problematic. For example, there is a
blackbox package that provides /usr/bin/blackbox already in Fedora. Other
puzzles have very generic names: cube, guess, map, mines... I suggest you to
rename all the puzzles, something like puzzle_name or puzzle-name
   * You are putting the desktop files in a directory inside
/usr/share/applications. I think is clearer to put them all in the main
directory and use a prefix if necessary (the different openoffice applications
follow this approach)
   * The license text must be included in %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.