[Bug 466692] Review Request: iml - Finds solutions to systems of linear equations over integers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466692


Patrice Dumas <pertusus at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
               Flag|                            |fedora-review+




--- Comment #3 from Patrice Dumas <pertusus at free.fr>  2008-10-19 06:22:29 EDT ---
* rpmlint gives:
iml-debuginfo.i386: E: empty-debuginfo-package
which is against the guidelines, but I don't think this is important (and
besides I think it is a bug in rpm, not to have debug info extracted from
static libs).

* follow relevant guidelines
* free software, no license included because upstream doesn't ship a license
consistent with the code
* match upstream:
03a2e361bf9574ae8d32c19a392eeb66  iml-1.0.2.tar.gz
* all static correctly packaged library
* %files section right

One suggestion, use
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' too tentatively
keep header file timestamps.

Also you should contact upstream to ask them to change the COPYING
file. (well in fact the license isn't that clear when repl/ is used, 
but it isn't th ecase in fedora, and in any case they should clarify 
the license).

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.