[Bug 226526] Merge Review: vim

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226526





--- Comment #13 from Ruben Kerkhof <ruben at rubenkerkhof.com>  2008-10-19 08:09:38 EDT ---
Review for release 1.fc10:
* RPM name is OK
* Source vim-7.2.tar.bz2 is the same as upstream
* Source vim-7.2-lang.tar.gz is the same as upstream
* Source vim-7.2-extra.tar.gz is the same as upstream
* Source forth.vim is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of vim-minimal looks OK
* rpmlint of vim-X11 looks OK
* rpmlint of vim-debuginfo looks OK
* rpmlint of vim-enhanced looks OK
* rpmlint of vim-common looks OK
* File list of vim-minimal looks OK
* File list of vim-X11 looks OK
* File list of vim-debuginfo looks OK
* File list of vim-enhanced looks OK
* File list of vim-common looks OK
* Config files of vim-minimal looks OK
* Config files of vim-enhanced looks OK
* Config files of vim-common looks OK

Needs work:
* Desktop file: the Categories tag should not contain Application any more
  (wiki: Packaging/Guidelines#desktop)
* Desktop file: the category Application is not valid
  (http://standards.freedesktop.org/menu-spec/latest/apa.html)
* As vim ships icons in the hicolor directory, it should have "Requires:
hicolor-icon-theme" 
https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.html
* A few rpmlint warnings:
[ruben at slice vim]$ rpmlint vim-common-7.2.022-1.fc10.x86_64.rpm | grep spurious
vim-common.x86_64: W: spurious-executable-perm
/usr/share/doc/vim-common-7.2.022/README_ami.txt.info
vim-common.x86_64: W: spurious-executable-perm
/usr/share/doc/vim-common-7.2.022/README.txt.info
vim-common.x86_64: W: spurious-executable-perm
/usr/share/doc/vim-common-7.2.022/README_amibin.txt.info
vim-common.x86_64: W: spurious-executable-perm
/usr/share/doc/vim-common-7.2.022/README_amisrc.txt.info

* Like Robert said in comment #11, the man directories are not owned by any
package, please resolve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.