[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459979





--- Comment #18 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2008-10-20 11:28:18 EDT ---
(In reply to comment #15)
> Why exactly do you need to disable sse even for x86?
sse isn't present on all x86 CPU, Thus activating sse on suches CPU is totally
forbidden in Fedora for a binary. It is possible to have sse2 activated for a
library (see atlas for an example).
> The changes you make to filter_motion_est.c are illogical, but they are
> effective at suppressing the respective code (since this is not Darwin
> platform). The top-level Makefile helper config.mak defines a USE_MMX unless
> --disable-mmx. Does this make more sense?
Yes, this is a hack.
To fix this, it would be better to have a --disable-sse option. so it can be
disabled unless x86_64. (as all x86_64 have the sse2 cpu capability).
Of course, as the koji built showned. You cannot set -DARCH_X86 on ppc64, so
the cpu detection for the mlt build system should probably redesigned.
> 
> mlt-config should be deprecated because pkg-config files are also supplied.
> However, I do have to convert mlt++ over to pkg-config. I will do that now for
> the next release. Also, I will check to make sure kdenlive does not use it.
> I'll consider removing mlt-config as well.
I haven't tested it yet, but you should note that the last version of sox also
have pkg-config support after having dropped any sox-config file in the F-9
version.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.