[Bug 442714] Review Request: sat-solver - Satisfyability Solver library which can be used to compute inter-package dependencies.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=442714





--- Comment #36 from Debarshi Ray <debarshi.ray at gmail.com>  2008-10-21 00:22:21 EDT ---
+ RPMLint is not clean on SRPM:

[rishi at freebook SOURCES]$ rpmlint ../SRPMS/sat-solver-0.9.5-1.fc10.src.rpm 
sat-solver.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 17)
sat-solver.src: W: strange-permission sat-solver.spec 0775
sat-solver.src: W: strange-permission sat-solver-db-corruption-fix.patch 0775
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
[rishi at freebook SOURCES]$

RPMLint is not clean on build sub-packages:

[rishi at freebook SPECS]$ rpmlint sat-solver-perl
sat-solver-perl.x86_64: E: description-line-too-long The sat-solver-perl
package contains libraries and perl modules to be used inside
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
[rishi at freebook SPECS]$ rpmlint sat-solver-python
sat-solver-python.x86_64: E: description-line-too-long The sat-solver-python
package contains libraries and python modules to be used inside
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
[rishi at freebook SPECS]$

Pretty simple actually. Just replace the tab with equivalent number of spaces
on line 17 of sat-solver.spec, and make sure that the files in the SRPM have a
permission of 0644. Lines in the description should not exceed 80 characters.

+ Is this package not meant for Fedora 9? The sat-solver-0.9.5-rpm4.5.90.patch
patch broke the build on my Fedora 9 system. In case it is only meant for
Fedora 10 and above, you could add a versioned dependency on rpm-devel
(BuildRequires) and rpm-libs (Requires) to enforce this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.