[Bug 429882] Review Request: python-Levenshtein - Levenshtein distance measurement library in C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=429882





--- Comment #15 from Dwayne Bailey <dwayne at translate.org.za>  2008-10-21 11:02:16 EDT ---
(In reply to comment #14)
> Packaging code from a dead upstream poses a particular problem.  If there's
> really no upstream web site to refer to then it would make sense to specify no
> URL tag, or to continue to refer to the old location (in the hope that it will
> come back), but in either case it would be beneficial to add an explanatory
> comment to the spec.

Added comment and rather pointed to the pypi entry.

> The same goes for the Source1: URL; if there's no authoritative source for that
> file then you'll need to add a comment to that effect.  I'm guessing that the
> Source: URL is just pointing at your project's sourceforge site, and that
> you're just mirroring the dead upstream site.  

Found packages using the wayback machine and added comments to that effect.

> Or are you taking over
> maintenance of the code?

Simply mirroring and not taking over the code.

> The real concern with a dead upstream is ongoing maintenance and specifically
> security issues.  I don't see much possibility for security vulnerabilities in
> this code, but you never know, and if upstream is dead then the burden falls
> entirely on you, the maintainer, to deal with issues of that nature.  Anyway,
> it's up to you and I'm sure you're aware; I'm just making sure that it gets
> said at some point before the package is in the distro.

Yes am aware of these issues.

> So basically the spec just needs a little bit of commenting about the state of
> upstream and the lack of a download location for Source1:.  My checklist
> follows; since there's not really any upstream, several of my usual checklist
> items will be missing.

Done, mostly changes are simply commenting on the lack of upstream and pointing
to way back machine.  Rebuilt and installed using mock on 9 and rawhide. New
files here:

SRPM:
http://translate.sourceforge.net/releases/testing/fedora/python-Levenshtein-0.10.1-6.fc9.src.rpm

SPEC:
http://translate.sourceforge.net/releases/testing/fedora/python-Levenshtein-0.10.1-6.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.