[Bug 226212] Merge Review: OpenIPMI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226212





--- Comment #4 from Ville Skyttä <ville.skytta at iki.fi>  2008-10-22 11:58:14 EDT ---
Created an attachment (id=321170)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=321170)
Fix for issues 1-4

Ok, continuing review:

1) The use of private libedit deserves a TODO comment in the specfile if
modifying the package to use system libedit is not feasible at this point.

2) Parallel make is not used - for a reason it seems (fails in some python
build phase), this is also a good thing to document in the specfile.

3) There are some typos in various summaries and descriptions.

4) .cvsignore and sources in CVS still contain the ipmitool tarball.

5) openipmigui does not start (F-9 x86_64, non-IPMI system):

$ openipmigui
Traceback (most recent call last):
  File "/usr/bin/openipmigui", line 310, in <module>
    run(sys.argv)
  File "/usr/bin/openipmigui", line 294, in run
    ui = gui.IPMIGUI(top, mainhandler)
  File "/usr/lib64/python2.5/site-packages/openipmigui/gui.py", line 209, in
__init__
    self.tree = Tix.Tree(objpane, options="hlist.columns 2")
  File "/usr/lib64/python2.5/lib-tk/Tix.py", line 1519, in __init__
    ['options'], cnf, kw)
  File "/usr/lib64/python2.5/lib-tk/Tix.py", line 307, in __init__
    self.tk.call(widgetName, self._w, *extra)
_tkinter.TclError: unknown color name "{#d9d9d9}"

6) openipmigui should have a .desktop file.

7) Can openipmigui be usefully be run as non-root?  I'm unable to test because
of 5) above.  If not, should be changed to use consolehelper(-gtk).

Fix for issues 1-4 above is attached (I could commit it myself, but CVS ACLs
prevent me).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.