[Bug 467655] Review Request: yafaray - a raytracer for Blender.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jochen at herr-schmitt.de




--- Comment #5 from Jochen Schmitt <jochen at herr-schmitt.de>  2008-10-23 13:31:44 EDT ---
Some Comments:

Good:

+ Local build works fine
+ Blender scripts are in the right directory:

Bad:

- Build failed on koji
  http://koji.fedoraproject.org/koji/taskinfo?taskID=898469

  Reason: Wrong BR to libxml-devel, You will need a BR to libxml2-devel.

- Rpmlint complaints source rpm

  $ rpmlint -i yafaray-0.1.0-4.fc9.src.rpm
yafaray.src:43: W: rpm-buildroot-usage %prep # fixes %{buildroot} in
libyafaraycore.so
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.

- Rpmlint warning to yafaray binary rpm:
   $ rpmlint -i yafaray-0.1.0-4.fc9.x86_64.rpm
yafaray.x86_64: W: no-soname /usr/lib64/libyafaraycore.so
yafaray.x86_64: W: no-soname /usr/lib64/libyafarayqt.so
yafaray.x86_64: W: no-soname /usr/lib64/libyafarayplugin.so
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

- Rpmlint complaints yafary-blender rpm:
  $ rpmlint -i yafaray-blender-0.1.0-4.fc9.x86_64.rpm 
yafaray-blender.x86_64: W: no-documentation                              
The package contains no documentation (README, doc, etc). You have to include
documentation files.                                                         

yafaray-blender.x86_64: E: wrong-script-interpreter
/usr/share/blender/scripts/yaf_export.py "BPY"                                  
This script uses an incorrect interpreter.                                      

yafaray-blender.x86_64: E: non-executable-script
/usr/share/blender/scripts/yaf_export.py 0644
This text file contains a shebang or is located in a path dedicated for         
executables, but lacks the executable bits and cannot thus be executed.  If     
the file is meant to be an executable script, add the executable bits,          
otherwise remove the shebang or move the file elsewhere.                        

yafaray-blender.x86_64: E: wrong-script-interpreter
/usr/share/blender/scripts/yaf_light.py "BPY"
This script uses an incorrect interpreter.

yafaray-blender.x86_64: E: non-executable-script
/usr/share/blender/scripts/yaf_light.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

yafaray-blender.x86_64: E: wrong-script-interpreter
/usr/share/blender/scripts/yafaray_ui.py "BPY"
This script uses an incorrect interpreter.

yafaray-blender.x86_64: E: non-executable-script
/usr/share/blender/scripts/yafaray_ui.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

yafaray-blender.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/blender/scripts/_yafrayinterface.so
This package installs an ELF binary in the /usr/share  hierarchy, which is
reserved for architecture-independent files.

yafaray-blender.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/blender/scripts/_yafqt.so
This package installs an ELF binary in the /usr/share  hierarchy, which is
reserved for architecture-independent files.

- Source contains not full qualified URI.
  If you have got the sources from svn, please add a comment on top of the
  source Statement. Please specified the release wihich you have chechout
  from svn.

- %{datadir}/blender/scripts is owned by the blender package.

Questions:
* Why do you have the sub packages yarafay and yarafay-blender?
* Why did you have uncomment the Provides and Obsoletes Statements?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.