[Bug 466301] Review Request: ario - Music Player Daemon Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466301


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-23 14:06:33 EDT ---
Some notes:

* License
  - License tag should be "GPLv2+".

* Redundant BuildRequires
  - Please try to remove redundant BuildRequires
    * gtk2-devel is required by libglade2-devel
    * glib2-devel is required by gtk2-devel
    * avahi-devel is required by avahi-glib-devel
    * libglade2-devel is required by libgnomeui-devel
        and libgnomeui-devel is required by libgnomedb-devel

* perl module dependency
  - For rpms providing perl module virtual Provides,
    please use perl module names for (Build)Requires, not
    using rpm names directly:
    https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides
    In this case "BuildRequires: perl(XML::Parser)" must be
    used.

* Unneeded Requires:
  - "Requires: gtk2" and so on must all be removed.
    rpmbuild checks the dependencies related to libraries
    automatically and adds them to the rebuilt binary rpms:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Requires

* Timestamps
  - To keep timestamps on installed files as much as possible,
    please consider to use:
--------------------------------------------------
make install DESTDIR=%{buildroot} INSTALL="install -p"
--------------------------------------------------
    This method usually works for Makefiles generated by
    recent autotools.

* desktop file install
  - When desktop file is to be installed, desktop-file-{install,validate}
    must be used:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

  ! By the way for Icon entry "Icon=ario" is preferred:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files

* %find_lang
  - gettext .mo files must be handled by %find_lang:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

* Static archives
  - static archives *.a files are not needed for this package
    and must be removed:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries

* Documents
  - Usually "INSTALL" file is for people who want to compile and install
    a package by themselves and is not needed for people using rpm.

  - There is no need to ship zero-size "README" file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.