[Bug 466777] Review Request: perl-Satcon - Framework for configuration files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466777


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #5 from Jason Tibbitts <tibbs at math.uh.edu>  2008-10-23 16:00:55 EDT ---
(In reply to comment #4)

> The provided Makefile will checkout the git to the tag perl-Satcon-1.6-1
> (commits after this tag are ignored) and make srpm from that version.

No, it will checkout whatever git tag the makefile in git head happens to
specify.  If six months from now, it is altered to check out version 2.0 then
those instructions will no longer be correct.  In fact, didn't you just alter
it to check out 1.7?  How would I now check out 1.6?

> You know... I did not write that code. I just take the code as is and try to
> include it in Fedora. The code is several years old.

Well, it is my job as the reviewer to ask those questions.  It's OK if the
names need to be that way because they've been that way for ages and other
software expects them.

> Yeah there was hardcoded version in module. I removed it:

It is normal for Perl modules to indicate their versions, but I don't see any
problem if you don't want to do that, although you then cannot have
version-specific "use" statements in code which uses this module (and hence no
automatic version-specific rpm dependency generation).  I doubt that would make
any difference to your application, though.

I will finish up this review when I get home.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.