[Bug 459016] Review Request: bunny - Instrumented C code security fuzzer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459016





--- Comment #3 from Rakesh Pandit <rakesh.pandit at gmail.com>  2008-10-24 01:26:33 EDT ---

xx - package does not meet Packaging Guidelines
    + Instead of just replacing -03 with -02 in the Makefile, you should try to
      use the value of RPM_OPT_FLAGS or %{optflags} as CFLAGS. See
      https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
      In this case, you could use:
      make CFLAGS=$RPM_OPT_FLAGS

It has a hand coded Makefile with hard written CFLAGS so replacing seems to me
okay


    + According to
      https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps you
      should use 'install -p'.

Done

    + You could consider adding CHANGES to %doc as it gives an indication of
      the direction the project is taking.

Done

xx - ExcludeArch is needed
     The upstream page (http://code.google.com/p/bunny-the-fuzzer/) says:
     "Bunny is currently known to support Linux, ... on IA32 and IA64
     systems."
     One should note that IA64 is different from x86_64 or amd64. So it would
     be a good idea to cross-check whether IA64 has been mistakenly used to
     refer to x86_64 or amd64, and whether x86_64 or amd64 is supported or not.
     I think that x86_64 is supported since it seemed to work with gcc.x86_64.
     In case IA64 has been mistakenly used, we should ExcludeArch ia64,
     alongwith the other secondary architectures (ie., alpha, arm, s390, sparc)
     which might not be supported.

>From http://code.google.com/p/bunny-the-fuzzer/wiki/BunnyDoc 

"""The only platforms known to work fine are Linux, flavors of BSD, and Cygwin
on IA32 platforms. Support for 64-bit and other unix systems is not confirmed.
There is no support for non-x86 architectures, although this requires very few
tweaks to correct. """

so ia32 it works. ia64 and other non-x86 need to be excluded.


Done

http://rakesh.fedorapeople.org/srpm/bunny-0.93-2.fc10.src.rpm -> SRPM
http://rakesh.fedorapeople.org/spec/bunny.spec -> SPEC

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.