[Bug 462813] Review Request: ldtp - Desktop testing framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462813





--- Comment #4 from Rakesh Pandit <rakesh.pandit at gmail.com>  2008-10-24 02:36:20 EDT ---



[rpmbuild at rocky-test i386]$ rp  ldtp-1.3.0-1.fc10.i386.rpm
ldtp.i386: E: non-executable-script
/usr/lib/python2.5/site-packages/ldtplib/__init__.py 0644
ldtp.i386: E: non-executable-script
/usr/lib/python2.5/site-packages/ldtplib/ldtprecorder.py 0644
ldtp.i386: E: non-executable-script
/usr/lib/python2.5/site-packages/ldtplib/libldtpcodegen.py 0644
ldtp.i386: E: non-executable-script
/usr/lib/python2.5/site-packages/ldtplib/ldtpcommon.py 0644
1 packages and 0 specfiles checked; 4 errors, 0 warnings.

May be use
sed -e '/^#!\//,1 d' -i %{buildroot}/%{python_sitearch}/ldtplib/<file>

[rpmbuild at rocky-test SRPMS]$ rp -i ldtp-1.3.0-1.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[rpmbuild at rocky-test i386]$ rp -i ldtp-debuginfo-1.3.0-1.fc10.i386.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Builds fine:
http://koji.fedoraproject.org/koji/taskinfo?taskID=900276

Review ldtp

rpmlint - x needs work
naming - OK
packaging guidelines - OK
license - OK
license field - OK
spec file legible and written in American English - OK
source matches upstream - OK (md5sum)
architectures supported - OK
build Require - OK
locale - N/A
directories owned - OK
no duplicate files - OK
permissions - OK
%install and %check have " rm -rf %{buildroot} " - OK
description and summary - OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.