[Bug 468189] Review Request: rear - Relax and Recovery (disaster recovery framework)

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 25 14:08:54 UTC 2008 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468189





--- Comment #8 from Fabian Affolter <fabian at bernewireless.net>  2008-10-25 10:08:53 EDT ---
Once again.

Source0: http://downloads.sourgeforge.net/%{name}-%{version}.tar.gz

- It's 'sourceforge', just a type...

Release: 1%{?dist}

- After you made any changes, please bump the release.

%changelog -> rpmlint issue
* Thu Oct 24 2008 Gratien D'haese
- rewrote rear.spec for FedoraCore Packaging request
* Tue Aug 28 2006 Schlomo Schapiro
- Initial RPM Release

- https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
  Example:
  * Wed Jun 14 2003 Joe Packager <joe at gmail.com> - 1.0-2
  - Added README file (#42).
                                                      ^   ^
                                                      |   |
                                This is the version ---   |
                                This is the release  ------

  BTW, it's only Fedora, we don't use Core anymore.

I'm able to build your package but rpmlint complain about a lot of stuff...

[rpm at laptop024 SRPMS]$ rpmlint -i rear-1.7.7-1.fc9.src.rpm 
rear.src: W: non-standard-group System/Archiving
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[rpm at laptop024 noarch]$ rpmlint -i rear-1.7.7-1.fc9.noarch.rpm 
rear.noarch: W: non-conffile-in-etc /etc/rear/Linux-ia64.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: E: script-without-shebang /usr/share/rear/lib/cfg2html-linux
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/GNU/Linux.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/EFI_readme.txt
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/doc/rear-1.7.7/DEVELOPMENT
rear.noarch: W: non-conffile-in-etc /etc/rear/templates/RESULT_usage_USB.txt
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: W: dangling-relative-symlink /usr/share/rear/skel/default/bin/sh
bash
The relative symbolic link points nowhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/Linux-i386.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/rear/pack/hpasmcliOutput.txt
rear.noarch: E: script-without-shebang
/usr/share/rear/verify/TSM/default/40_verify_tsm.sh
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rear.noarch: W: hidden-file-or-dir /usr/share/rear/skel/default/.bash_history
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/USB_syslinux.cfg
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: W: non-conffile-in-etc /etc/rear/Debian/ia64.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/RESULT_usage_ISO.txt
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /etc/rear/hpasmcliOutput.txt
rear.noarch: W: non-conffile-in-etc /etc/rear/hpasmcliOutput.txt
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: W: non-conffile-in-etc /etc/rear/Ubuntu/7.10.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/rear/doc/DEVELOPMENT
rear.noarch: W: dangling-relative-symlink /usr/share/rear/skel/default/init
bin/init
The relative symbolic link points nowhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/RESULT_usage_PXE.txt
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.7/README
./usr/share/rear/README
The relative symbolic link points nowhere.

rear.noarch: E: zero-length /usr/share/rear/skel/default/var/log/lastlog
rear.noarch: W: non-conffile-in-etc /etc/rear/Linux-x86_64.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.7/contrib
./usr/share/rear/contrib
The relative symbolic link points nowhere.

rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.7/CHANGES
./usr/share/rear/CHANGES
The relative symbolic link points nowhere.

rear.noarch: E: zero-length /usr/share/rear/dr/hpasmcliOutput.txt
rear.noarch: W: non-conffile-in-etc /etc/rear/default.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: E: script-without-shebang
/usr/share/rear/dr/GNU/Linux/95_cfg2html.sh
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/validated/SUSE_LINUX/10/i386.txt
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/rear/skel/default/var/lib/nfs/state
rear.noarch: E: script-without-shebang
/usr/share/rear/lib/mkrescue-functions.sh
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/RESULT_mailbody.txt
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/rear/skel/default/etc/mtab
rear.noarch: W: non-standard-group System/Archiving
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

rear.noarch: W: incoherent-version-in-changelog D'haese 1.7.7-1.fc9
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

1 packages and 0 specfiles checked; 12 errors, 23 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list