[Bug 468466] Review Request: libgksu - Simple API for su and sudo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468466





--- Comment #3 from Simon Wesp <cassmodiah at fedoraproject.org>  2008-10-25 17:54:33 EDT ---
Spec URL: 
http://cassmodiah.fedorapeople.org/libgksu-2.0.7/libgksu.spec

SRPM URL: 
http://cassmodiah.fedorapeople.org/libgksu-2.0.7/libgksu-2.0.7-2.fc10.src.rpm


[!] Rpmlint output:
     Source RPM:
     [rpm at laptop024 SRPMS]$ rpmlint -i libgksu-2.0.7-1.fc9.src.rpm 
     1 packages and 0 specfiles checked; 0 errors, 0 warnings.

     Binary RPM(s):
     [rpm at laptop024 i386]$ rpmlint libgksu-*
     libgksu.i386: W: non-conffile-in-etc /etc/gconf/schemas/gksu.schemas
     3 packages and 0 specfiles checked; 0 errors, 1 warnings.  

https://bugzilla.redhat.com/show_bug.cgi?id=454208#c4
  - We regards GConf schemas files as _not_ a configuration file
    so please remove %config(noreplace) attribution on GConf schemas file
    (even if rpmlint warns about it)


[!] The spec file handles locales properly.
     You added 'BuildRequires: gettext-devel'
     acc.
https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files 'BR:
gettext' is sufficient 

fixed


 [!] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
     - 'desktop-file-install --vendor="fedora" \' is obsolete for new packages.
       see https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

fixed


The .desktop file is in the wrong package.  I think that a better place is gksu
(#468467), or am I wrong?

gksu is just the frontend and the desktopfile links to the wizard application
that set the properties of the API, or am I wrong?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.