[Bug 435015] Review Request: gpp4 - LGPL CCP4 library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435015





--- Comment #17 from Tim Fenn <fenn at stanford.edu>  2008-10-27 16:29:35 EDT ---
(In reply to comment #16)
> Some notes
> 
> ? License
>   - License tag can be okay with LGPLv2 as README file
>     declares so, however all files under src/ directories
>     are actually under LGPLv2+.
>     Would you ask upstream about this? (as it is okay
>     with LGPLv2, this is not a blocker)
> 

Will do - will report back on this asap.

> * Source tarball
>   - The tarball in the srpm differs from what I could
>     download from the URL written as %SOURCE
> ------------------------------------------------------
> 514623 2008-06-10 05:21 gpp4-1.0.4-9.fc10.src/gpp4-1.0.4.tar.gz
> 498933 2007-09-03 00:00 orig/gpp4-1.0.4.tar.gz
> 
> 48931781425a5b79a8255ebefaed24b3  orig/gpp4-1.0.4.tar.gz
> 7494566588545eb167b1c4c6e486cdf4  gpp4-1.0.4-9.fc10.src/gpp4-1.0.4.tar.gz
> ------------------------------------------------------
> 

ah, stupid mistake on my part (was using a .tar.gz from a "make build"). 
Fixed.

> * Linkage error
>   - rpmlint shows
> ------------------------------------------------------
> gpp4.i386: W: undefined-non-weak-symbol /usr/lib/libgpp4.so.0.0.0 sincos
> gpp4.i386: W: undefined-non-weak-symbol /usr/lib/libgpp4.so.0.0.0 sqrt
> gpp4.i386: W: undefined-non-weak-symbol /usr/lib/libgpp4.so.0.0.0 rintf
> gpp4.i386: W: undefined-non-weak-symbol /usr/lib/libgpp4.so.0.0.0 lrint
> ------------------------------------------------------
>     For packages providing -devel subpackage these rpmlint warnings
>     cannot be allowed because these will cause linkage error when
>     using these libraries.
>     I guess linking to libm.so (-lm) will remove these warnings.
> 

Fixed.

> 
> * Duplicate documents
>   - Generally there is no need to include a document file as %doc
>     to both main and -devel packages.
> 

Fixed.

> * Timestamps
> ------------------------------------------------------
> make install DESTDIR=$RPM_BUILD_ROOT install='install -p'
> ------------------------------------------------------
>   - This should be "INSTALL='install -p'".
> 

Fixed.

> ? Another rpmlint issue
> ------------------------------------------------------
> gpp4-devel.i386: W: file-not-utf8
> /usr/share/doc/gpp4-devel-1.0.4/doc/latex/csym_f_page.tex
> ------------------------------------------------------
>   - Well it may be preferable to convert this file to UTF-8,
>     however I am not sure if tex supports UTF-8 tex file
>     (at least it is well-known that platex does not support
>      Japanese UTF-8 tex files...)

>From my experience with latex, a package has to be added to the document (utf8)
in order for latex to understand it.

new spec: http://www.stanford.edu/~fenn/packs/gpp4.spec
updated srpm: http://www.stanford.edu/~fenn/packs/gpp4-1.0.4-10.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.