[Bug 468453] Review Request: shed - simple ncurses based hex editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468453


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-10-27 20:17:56 EDT ---
Just some small comments on your spec file

Requires: ncurses
 - not needed because ncurses-devel is a BR 

make
 - should be make %{?_smp_mflags} acc. to
https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#.25build_section

chmod 0755 $RPM_BUILD_ROOT/%{_bindir}/shed
 - Is this really needed?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.