[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 29 00:17:21 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468631





--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2008-10-28 20:17:20 EDT ---
Thanks Ralf for the comments

(In reply to comment #1)
> Just a couple of remarks:
> 
> (In reply to comment #0)
> MUSTFIX
> - libgarmin.a is missing from *-devel
> Without, this *-devel rpm is widely useless.

fixed

> - package doesn't support shared libraries
> => Must add *-static magic to *-devel

fixed.  I added '--enable-static=no' to %configure

> - Wrong License:
> Your spec says: License:        GPLv2+
> Several files (e.g. libgarmin.h and COPYING) inside of the sources say:
>  GPLv2 *only*.

fixed

SPEC: http://fab.fedorapeople.org/packages/SRPMS/libgarmin.spec
SRPM:
http://fab.fedorapeople.org/packages/SRPMS/libgarmin-0-0.2.20081026svn.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list