[Bug 444366] Review Request: deco - Extractor for various archive file formats

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 29 02:53:50 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=444366


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |orcanbahri at yahoo.com
               Flag|                            |fedora-review?




--- Comment #18 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-10-28 22:53:49 EDT ---
Package is in good condition. My notes:

* Source0 must be given in full URL.

* I would include the test.py and demo.py inside the %doc files, because they
give a nice demonstration about how gnuplot-py should be used. You don't need
to remove shebangs from them. Just do:
   mv %{buildroot}%{python_sitelib}/Gnuplot/demo.py doc/Gnuplot/
   mv %{buildroot}%{python_sitelib}/Gnuplot/test.py doc/Gnuplot/
in the %install section. Or maybe you may want to install them inside an
"examples" directory under %doc.

Otherwise the package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list