[Bug 468453] Review Request: shed - simple ncurses based hex editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468453





--- Comment #3 from Fabian Affolter <fabian at bernewireless.net>  2008-10-29 09:25:16 EDT ---
Just two small thing before I will do a full review. 

There is a typo in the 'Source0'
 - Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
                           ^
                           ¦_ the 's' is missing
   https://fedoraproject.org/wiki/Packaging/SourceURL

BuildRoot
 - Your current BuildRoot is a bit unusual.  Please check the examples of the
recommanded BuildRoots
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

%changelog
 - Every time you make changes in your spec file, you should bump the release
and create a new entry in your changelog. I think this this time you can
summarize all changes and bump the release to '2'
  https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

%files
 - If you like to can replace 'shed' with the macro %{name}.  But that is only 
cosmetically and depends on the packager's flavor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.