[Bug 468562] Review Request: basket - Taking care of your ideas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468562





--- Comment #9 from Hans de Goede <hdegoede at redhat.com>  2008-10-30 09:39:21 EDT ---
(In reply to comment #1)
> I had to make a couple changes so here are new URLs:
> 
> Spec URL:
> http://8uxodw.bay.livefilestore.com/y1phVJHr_dSr1gMt0-rHuTVAAUTrX26o8YAnkwqvlxzL4LOLRUxKl5GDl8ohc8QJL15RsU9md2O_PPWC_7Hv5uNOg/basket.spec?download
> 
> SRPM URL:
> http://8uxodw.bay.livefilestore.com/y1pShllREhh39cP2V-sNezg4d6KwykdOHLVDBpDfaDdJDNACluD0spLx3PSi7-UQiwHzprAM7W-fxo/basket-1.0.3.1-1.fc10.src.rpm?download
> 
> Output of rpmlint:
> 
> basket.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 5)
> 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
> ^^^ Ignoring this one because it's just complaining about my formatting.
> 

I know it may seem a bit pedantic, but this is a MUST FIX item, iow not
something to be ignored. Mixing spaces and tabs is bad. So choose one and stick
to it, note that the Fedora standard more or less is to use spaces, but tabs
are allowed too if you prefer as long as you are consistent.

> basket.i386: W: file-not-utf8 /usr/share/doc/basket-1.0.3.1/AUTHORS
> ^^^ Ignoring the first warning because the authors name has a é and a û in it.

This is another MUST FIX item, the trick is to change the encoding in %setup
using iconv, so in this case you should add the following lines under %setup:
iconv -f ISO_8859-1 -t UTF-8 AUTHORS > AUTHORS.tmp
touch -r AUTHORS AUTHORS.tmp
mv AUTHORS.tmp AUTHORS

> basket.i386: E: invalid-soname /usr/lib/libbasketcommon.so libbasketcommon.so
> 2 packages and 0 specfiles checked; 1 errors, 1 warnings.
> I'm not sure what to do about the second error.  Is there even a way I can fix
> that or is it an upstream problem?

With new packages we normally fix issues like this with Fedora specific
patches, but given that this package is already in Fedora, I think we can leave
this as is for now. You should file a bug upstream though, asking them to
change this into a properly versioned .so file with a proper soname.


I've done a review of this package, which besides the things mentioned above
also has found the following issues:

MUST FIX
--------
* This line in the 2 post script is wrong:
-p /sbin/ldconfig
  That should be just:
/sbin/ldconfig

SHOULD FIX
----------
* Update the description as discussed in previous comments

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.