[Bug 459878] Review Request: genome - Package for the Genome Project

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 30 19:20:30 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459878





--- Comment #20 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-30 15:20:29 EDT ---
For -6: (still I just looked at your spec file)

* Macros
  - For example /usr/share must be %{_datadir}
    https://fedoraproject.org/wiki/Packaging/RPMMacros

(In reply to comment #17)
> (In reply to comment #15)
> > * Virtual Provides must usually be EVR specific (Vitual Provides
> >   without EVR information caused upgrading path problem many
> >   times...)
> > 
> 
> Fixed.

  - This means that "Provides: rubygem-genome-bootstrap" must usually
    be "Provides: rubygem-genome-bootstrap = %{version}-%{release}",
    for example.

> > * "Requires: genome" is redundant when "Requires: gnome-lib" is
> >   present (currently, however see below)
> > * I guess that the dependency between genome and genome-lib
> >   is opposite
> It allows for faster dep-solving if Requires: genome is in the requires for a
> package next to Requires: genome-lib, because the "new" deps won't have to be
> looped through (the dep is already resolved during the first run in the loop)

  - What I mean here is that "genome" package should have 
    "Requires: genome-lib" and genoe-lib subpackage should _not_ have
    "Requires: genome" (e.g.
     http://cvs.fedoraproject.org/viewvc/rpms/lzma/devel/lzma.spec?view=co )

> > * When using "cp" or "install" commands, add "-p" option
> >   to keep timestamps on installed files:
> >   https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
> Fixed.

  - Not yet... (you should use -p option also for "cp" command)

> > * The scripts related to SysVinit script are wrong at
> >   several points.
> >   Also some Requires(preun) or so are missing.
> >   Please refer to:
> >  
> >   https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_in_spec_file_scriptlets
> >   https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Syntax
> > 
> 
> Fixed.

  - Please recheck these. -6 srpm scriptlets for SysVInit scripts
    are still wrong.
    Example:
--------------------------------------------------------
%preun bridge
/sbin/chkconfig --del genome-bridge
--------------------------------------------------------
    * Note that when genome-bridge is to be upgraded, %preun of
      old genome-bridge is done 
      _after_ newer genome-bridge is installed and all %post scripts
      in new genome-bridge is executed:
     
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Scriptlet_Ordering

      As the result, with this scriptlet when genome-bridge is
      upgraded chkconfig entry of gnome-bridge is completely
      deleted because of _old_ %preun script.

      (There are also some other mistakes in other scriptlets.
       Please recheck SysVInitScripts wiki)

> > * Please make it sure that directories which are created when
> >   installing a package are correctly owned by the package.
> >   There are some directories which are not owned by any packages
> >   or when the package is installed:
> >  
> I think I got this one nailed but I'd appreciate some verification.

  - Please check the following directories:
-------------------------------------------------------
%{_datadir}/genome-replace-self/
-------------------------------------------------------

> 
> > * We recommend %defattr(-,root,root,-)
> >   Also on some subpackages %defattr is completely missing
> >   (please use rpmlint to detect this type of packagins error)
> rpmlint does not say anything about missing defattr's

  - You can use rpmlint also for src.rpm (still complains)

> > * Files under %_datadir/doc are automatically marked as %doc
> I'm not sure what this means. I get what it means but I'm not sure what it
> applies to as far as the package is concerned.

  - This means that "%doc" specification in 
    "%doc %{_datadir}/doc/genome-dsl-%{version}" is redundant, for example.

* macros in comments
-------------------------------------------------------
#%files docs
#%defattr(-,root,root,-)
#%doc COPYING
#%config(noreplace) %{_sysconfdir}/httpd/conf.d/genome-docs.conf
#/%{_localstatedir}/www/genome/docs
-------------------------------------------------------
  - Well this is a bit dangerous because rpm tries to expand macros
    even in comments.
    In comments or %changelog, please use %% instead of % to prevent
    macros from being expanded.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list