[Bug 467179] Review Request: pngcrush - Optimizer for PNG (Portable Network Graphics) files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467179


Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |loganjerry at gmail.com
         AssignedTo|nobody at fedoraproject.org    |loganjerry at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Jerry James <loganjerry at gmail.com>  2008-10-30 16:29:48 EDT ---
I'll take this.  Before I do a full review, I see a few problems that need to
be corrected.

First, RPM_OPT_FLAGS are not respected during compilation.  Change the make
invocation in the spec file to read:

%{__make} %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"

Second, the source tar file includes all of the sources of cexcept, zlib, and
libpng.  This leads directly to the next two problems.

Third, the program should be linked against -lz, and -lpng to pick up the
latest and greatest security fixes, but isn't.  This is required by the
Packaging Guideliness.  (See "Duplication of system libraries".)  I realize
that this package is shipping source for later versions of libpng and zlib than
Fedora currently ships, but I don't see that as changing the situation.

Fourth, there is no Fedora package of cexcept.  It is a compile-time-only
artifact, so that might be okay, but it has a different license, so I'm not
sure.  If you know of an official Fedora statement that this kind of thing is
okay, please point me to it.  Otherwise, you'll probably need to package
cexcept first.

Fifth, the license is not the same text as the zlib license.  The intent seems
to be the same, but I am not a lawyer.  Please check with fedora-legal that
this license can be called "zlib".

Sixth, when I tried to compile with the system versions of zlib and libpng, I
got this:

pngcrush.c: In function ‘main’:
pngcrush.c:2891: error: ‘chunk_name’ undeclared (first use in this function)
pngcrush.c:2891: error: (Each undeclared identifier is reported only once
pngcrush.c:2891: error: for each function it appears in.)

This appears to be a pngcrush bug.  Starting on line 2821, there is an #if
expression that is missing "|| !defined(PNG_sTER_SUPPORTED)".  Please report
this bug upstream.

Finally, please consider whether ChangeLog.txt ought be included as a %doc
file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.