[Bug 467180] Review Request: pngnq - tool for quantizing PNG images in RGBA format Version

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 31 07:04:58 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467180


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|                            |182235
         AssignedTo|nobody at fedoraproject.org    |orcanbahri at yahoo.com
               Flag|                            |fedora-review?




--- Comment #3 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-10-31 03:04:57 EDT ---
Other than the license issue a few other things need to be sorted out:

* Although it is an almost obsolete field I think the Group should be
Applications/Multimedia

? You can do a
   make all
to build pngcomp in addition to pngnq and then package it together :)
(Don't forget to include the other README file if you do this)

* We recommend %defattr(-,root,root,-)

* It would be nice if you briefly explain in the SPEC file what the patches do.
Did you submit them upstream (especially the getopt patch)? If so, please
provide the links (in the SPEC file) to their tracking system.

* Package does not honor Fedora specific compilation flags. Please see:
http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

--
Also, let's keep FE-Legal blocked until the license issue is solved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list