[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469189





--- Comment #4 from Tim Lauridsen <tim.lauridsen at googlemail.com>  2008-10-31 08:35:38 EDT ---
# rpmlint Download/system-autodeath-0.2-1.src.rpm 
system-autodeath.src: W: no-version-in-last-changelog
system-autodeath.src: W: strange-permission system-autodeath.spec 0600
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

These should be OK.

# rpmlint ~/rpmbuild/RPMS/noarch/system-autodeath-0.2-1.noarch.rpm 
system-autodeath.noarch: W: non-conffile-in-etc
/etc/sysconfig/system-autodeath.conf
system-autodeath.noarch: W: no-version-in-last-changelog

/etc/sysconfig/system-autodeath.conf should be a config file in the %files
section

(. not checked, * = ok, X = not OK)

MUST:
* Package is matching naming guidelines.
* spec file in named %{name}.spec 
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible have the right good license shortname :
GPLv2+
* License file must be in %doc (it it exists)
* Spec file is written in American English
* Spec file is legible.
* Sources match upstream.
  MD5SUM:
 ea889c8a377cac44361576f6112f2868 
/home/tim/rpmbuild/SOURCES/system-autodeath-0.2.tar.gz
 ea889c8a377cac44361576f6112f2868 
/home/tim/Download/system-autodeath-0.2.tar.gz


* summary and description fine
* correct buildroot
X %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager/Vendor/Distribution/Copyright tags not used
* Summary tag does not end in a period
* Package compiles and build into RPM's on : i386 etc.
* no Exclude Arch 
* BuildRequires for all build requerements (- the ones on the Exception list)
* no locales
* no shared libs 
* Package own all created directories.
* No duplicate files in %files 
* Every %files section includes a %defattr(...) line
* Package has a %clean with a rm -rf %{buildroot} or $RPM_BUILD_ROOT
* consistently use of macros
* Package contains code or or permissable content.
* No large documentation
* files in %doc dont affect runtime.
* no header files
* no static libs
* package has no pkgconfig (.pc) files 
* no -devel subpackage 
* no ..la libtool archives
* not a gui application 
* package don't own files and dirs owned by other packages.
* %install starts with an rm -rf %{buildroot} 
* rpm package filenames is in valid UTF-8.
* no Rpath 
* no config files
* no %makeinstall used
* no Requires(pre,post)

Problems.
  %{?dist} is missing from release tag.
  /etc/sysconfig/system-autodeath.conf should be a config file in the %files
section

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.