[Bug 462535] Review Request: python-foolscap - Next-generation RPC protocol, intended to replace Perspective Broker

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 31 16:21:58 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462535


Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |limb at jcomserv.net




--- Comment #3 from Jon Ciesla <limb at jcomserv.net>  2008-10-31 12:21:57 EDT ---
Must:

BuildRequires:   python

See: https://fedoraproject.org/wiki/Packaging/Python

Files is python_sitelib are not in a module subdirectory, and should be.


David, I'd also like to see a more detailed review.  Early in learning the
review process, many find it helpful to use a template.  What I do is paste a
copy of the ReviewGuidelines into the bug, and go through it section by
section, annotating each with either OK or FIX, and summarizing at the end. 
This helps prevent omissions, and I speak from experience here. :)

Other than that and the above, I concur with your review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list