[Bug 474992] Review Request: libirman - Library for IRMAN hardware

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474992





--- Comment #12 from Jason Tibbitts <tibbs at math.uh.edu>  2009-04-01 14:24:22 EDT ---
Sorry for taking so long; I had too many reviews in flight and somehow this one
slipped through the cracks.  Please feel free to ping me if I've let something
go idle for too long.

You seem to have clarified the license situation well enough, and the static
stuff is gone, which is good.

However, it's kind of weird to patch up to a CVS snapshot by including a patch
thats larger than the source tarball.  It's OK to pick patches out of the
upstream SCM if that's what you want, but if you want to ship a snapshot, it's
better to simply do a checkout and include that as your tarball.  See
http://fedoraproject.org/wiki/Packaging/SourceURL for information on how we do
this.  Basically, you make the tarball but include instructions for generating
it so that someone else who comes along will know where it came from. 
Currently you just have this big patch with no information on duplicating it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.