[Bug 492979] Review Request: python-cliutils - A collection of utilities easing the creation of command line scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492979


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-04-03 12:23:39 EDT ---
- Don't use macros for cat or rm. (Macro for python is in the python guideline
for some reason.)

- Don't use filelist.

- Use %defattr(-,root,root,-)

- Remove empty %post and %postun sections.

- Change

BuildRequires: python, python-devel, python-setuptools

to

BuildRequires: python-setuptools-devel

(BR python is redundant, since python-devel already pulls that in. If you BR
python-setuptools-devel, then it pulls setuptools and python-devel
automatically.)

You don't even need python-setuptools unless you want to build for EPEL. For a
plain Fedora spec you'd just need BR: python-devel. (In the python guideline
the BR is actually just python.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.