[Bug 481717] Review Request: ugene - genome analysis suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481717





--- Comment #12 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-04-07 15:18:29 EDT ---
Created an attachment (id=338581)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=338581)
Patch to compile 1.4.1 with g++ 4.4

Some notes for 1.4.1-1:

* Licensing
  - Now also files under src/plugins_3rdparty/script_debuger/src/qtscriptdebug/
    are under GPLv2 (not under GPLv2+).
    (The license tag is still okay with "GPLv2+ and GPLv2")

* build failure
  - Actually your srpm does not build.
  ! On Fedora Qt4 "qmake" is renamed to %_bindir/qmake-qt4
    (or you can use %_qt4_bindir macro, which is /usr/lib/qt4/bin/qmake
     on i586)

    and Qt4 "lrelease" is renamed to %_bindir/lrelease-qt4.
    So you have to modify src/qtranslate.cmd, otherwise as I said
    before trying to launch ugene causes:
-------------------------------------------------------
Translation not found: transl_ja_JP
Translation not found: transl_en
No translations found, exiting
--------------------------------------------------------
    Currently (after changing "qmake" to "qmake-qt4") build.log says:
--------------------------------------------------------
    42  + qmake-qt4 -r INSTALL_BINDIR=/usr/bin INSTALL_LIBDIR=/usr/lib
INSTALL_DATADIR=/usr/share INSTALL_MANDIR=/usr/share/man
    43  ./qtranslate.cmd: line 1: lrelease: command not found
    44  ./qtranslate.cmd: line 2: lrelease: command not found
    45  cp: cannot stat `_debug/transl_en.qm': No such file or directory
    46  cp: cannot stat `_debug/transl_ru.qm': No such file or directory
--------------------------------------------------------

  ! And the attached patch is needed for g++ 4.4 .

* Desktop file
  - Installed desktop file must be treated by "desktop-file-install"
    or so:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

* Use of glob in %files
  - %files entry
--------------------------------------------------------
%files
%{_libdir}/*
--------------------------------------------------------
    is not acceptable
    - Because find-debuginfo.sh installs files for debugging into
      /usr/lib/debug (on i586) and %_libdir/* contains this
      directory. So some debuginfo files are also installed in
      ugene binary rpms, not only ugene-debuginfo rpm.
    This must be changed to %{_libdir}/ugene or so.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.