[Bug 454022] Review Request: coccinella - Chat client with whiteboard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454022





--- Comment #11 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-04-07 19:22:20 EDT ---
OK. Here's my review. There are some issues but most of them are very trivial.

* The new guidelines prefer usage of %global instead of %define. But I don't
think these lines are needed by this package anyways:
   %{!?tcl_version: %define tcl_version %(echo 'puts $tcl_version' | tclsh)}
   %{!?tcl_sitearch: %define tcl_sitearch %{_libdir}/tcl%{tcl_version}}
They are not used.

- the rpmlint "coccinella.noarch: E: explicit-lib-dependency tcl-zlib" can be
ignored since this package really needs this explicit dependency.

* Group: System Environment/Libraries
is wrong. Should this be Applications/Internet ?

* I believe that AUTHORS.txt should go to %doc.

? Should docs/ really go to %doc? I don't know what those files are for.

* There are many files under contrib/ directory that are marked BSD and they
end up in the final package. Hence, the package is GPLv3 and BSD.

* rpm -qplv coccinella-0.96.12-1.fc11.noarch.rpm |grep -- "-rwxr-xr-x"
shows a large amount of png, wav, ico and gif files with wrong executable
permissions. I wonder why rpmlint doesn't complain.

* Please swap the occurrence of $RPM_BUILD_ROOT with %{buildroot} for macro
consistency.

! desktop-file-validate on the .desktop file complains:
   coccinella.desktop: warning: key "Encoding" in group "Desktop Entry" is
deprecated

! Also please add a Comment=something to the .desktop file to please the gnome
users.

! You can use themes/Oxygen/icons/128x128/coccinella.png as the application
pixmap for better quality.

? About the software: 
   - Info->Update Check shows wrong version. No big deal though.
   - Info->About Coccinella says "Looking for Img..." but it did not find it
yet on my computer. No biggie either.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.