[Bug 494965] Review Request: pianobooster - A MIDI file player that teaches you how to play the piano

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494965


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-04-08 21:02:10 EDT ---
Here are my notes for this package (* need definite attention. ! are
suggestions):

* We need to package rtmidi seperately and link to it. I already packaged
rtaudio before. Things should be similar (you can take rtaudio SPEC file as
your starting point)

Note that rtmidi is MIT, but it is compatible with GPL.

! Please make use of the %{name} macro.

! I find it better to supply the .desktop file separately, to preserve the
original creation date. But that's a matter of taste.

! I prefer using sed+iconv instead of dos2unix to save a BR. But then again
this is a matter of taste. If you are going to use dos2unix, could you use the
-k flags to preserve timestamps?

* Similarly, please use the -p flag with install to preserve the timestamps (of
the .png files in this case)

! Please add a GenericName to the .desktop file. Also AudioVideo needs to be
added to the Category key, if you want this application to appear in Multimedia
group.

* There is a typo on the installation of the 64x64 icon. (32x32 should be
64x64)

* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.

! Summary seemed too long to me. It can be just something like "Piano Teacher"

! I think the comma should be removed from the end of this line (for proper
English):
   "The difference between playing along to a CD or a standard MIDI file,"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.