[Bug 490989] Review Request: subdownloader - A program for download/upload subtitles for videofiles and DVDs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490989


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk>  2009-04-09 02:06:53 EDT ---
1.) I believe this is not valid English (applies to %description as well)

Summary:        A program for download/upload subtitles for videofiles and DVDs

Might better be "Program to download movie subtitles" (keep it short and
concise).

2.) No useless comments

#cp -p subdownloader.xpm %{buildroot}%{_datadir}/pixmaps

3.) Do not use dist tag in changelogs

You may want to build the package for multiple branches.

None of the serious enough to block approval. Please address them upon import.

- SPEC is mostly clean and legible
- Noarch package, no compiler flags to use
- Filelist sane
- Requires/Provides sane
- Rpmlist mostly quiet (complains only about 3.)
- Written (apart from 1. in valid American English)
- License specified correctly (complete license not included by upstream)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.