[Bug 470703] Review Request: links 2 - text mode browser with graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470703


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(mpatocka at redhat.c
                   |                            |om)




--- Comment #29 from Lubomir Rintel <lkundrak at v3.sk>  2009-04-10 02:59:53 EDT ---
(In reply to comment #28)
> I don't know anything about NSS, I thought that it is used by Mozilla and I
> didn't even know that other projects could be compiled against it. Dost the
> conversion mean only a recompile and relink? Or do I have to rewrite some of
> the code?

NSS provides and OpenSSL compat library which implements most (though
definitely all) of OpenSSL API. See the patch included in the source package
(most of it is just configure script modifications and like two ifdefs or so)

> I may try to compile Links with NSS, but even if it succeeds, you won't get
> good testing with NSS soon, Links always used OpenSSL and it is long-term
> tested with it, so if you want something proven stable, use OpenSSL.

It will get testing in Fedora. I believe there's not that much to test in
SSL/TLS support anyways.

> BTW. why do you want NSS instead of OpenSSL?

Your license forbids use of OpenSSL.
See: http://www.gnome.org/~markmc/openssl-and-the-gpl.html

Besides that, NSS is used most of core SSL functionality in Fedora and pushing
the redundant oddly-licensed library away as much as we can is indeed good,
especially when it comes to cryptography where redundancy implies increased
risk of serious flaws.

> Regarding the config script --- there is a bug that it selects hardcoded
> directories first and the user directory last. Easy to fix. Just keep in mind
> that the configure script must be generated with autoconf 2.13 --- that was
> current version 10 years ago when Links project was started and support for all
> the operating systems is tested with it.  

Yup. If you have time, please take a look at the patch for NSS compatibility I
bundled with the package. As Ondrej suggested, you may not be satisfied with
it, but it's trivial enough for anyone to fit it their needs.

(In reply to comment #23)
> 2)
> Many warnings "pointer targets in passing argument <N> of <variable> differ in
> signedness" in build.log still ... upstream should address those...  maybe just
> adding Mikulas to that review could be ok.

Mikulas, any thoughts about these?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.