[Bug 490269] Review Request: xfglenses - Gravitational lenses visualization program

bugzilla at redhat.com bugzilla at redhat.com
Fri Apr 10 16:59:10 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490269





--- Comment #5 from Thibault North <thibault.north at gmail.com>  2009-04-10 12:59:10 EDT ---
> xfglenses.x86_64: W: incoherent-version-in-changelog 1-0-2 ['1.0-2.fc10',
>'1.0-2']
>3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fixed

>MUST: The sources used to build the package must match the upstream source, as
>provided in the spec URL. NEEDSFIX

Upstream has been notified a while ago, it's just a matter of time. I will
comment here again when it is done.

>MUST: Optflags are used and time stamps preserved. ???
>- No compiler commands are visible in the output.

There is one right after the green "Building C object
src/CMakeFiles/xfglenses.dir/xfglenses.c.o" (followed by compilation warnings),
march=i585 is used (eg)


>MUST: Desktop files are installed properly. ??
>- If the program starts just by calling the binary, then a Desktop file should
>be written.

Has been added in category "Education". Icon has been added to source package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list