[Bug 489233] Review Request: rmol - C++ Revenue Management Optimisation Library (RMOL)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489233


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

Bug 489233 depends on bug 488930, which changed state.

Bug 488930 Summary: "W: libdir-macro-in-noarch-package" in NO-noarch package with noarch subpackage
https://bugzilla.redhat.com/show_bug.cgi?id=488930

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |NEXTRELEASE



--- Comment #16 from Michael Schwendt <bugs.michael at gmx.net>  2009-04-13 06:26:05 EDT ---
* Looks good.

* Note though that typically one increases the "Release" value with every
modification of the package (this also aids reviewers who use rpmdev-diff and
similar tools). Your upstream tarball has also changed silently without
increasing the minor release version. Please avoid this in the future.

* If you like to continue with the Fedora Packager sign-up procedure prior to
completing the SOCI review, feel free to do so, and I'll approve your account
request.

$ sha1sum rmol-0.19.0-1.fc10.src.rpm rmol-0.19.0.tar.gz
a7ccc0cfb952a63123c7b9fff34ab93ae7b4d619  rmol-0.19.0-1.fc10.src.rpm
d29bb310952168a043e104d5dd66feb68d5e1476  rmol-0.19.0.tar.gz

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.